Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Host Details Locator Cleanup #1015

Merged
merged 3 commits into from
Dec 18, 2023
Merged

Host Details Locator Cleanup #1015

merged 3 commits into from
Dec 18, 2023

Conversation

sambible
Copy link
Contributor

Replace individual locators with HostDetailsCard widget, and remove unnecessary and unused entity methods.

These cards can easily be accessed through the get_details method instead.

Probably also worth stating that these cards aren't currently under test, and this PR doesn't remedy that, it just cleans up the locators and entities that were written when the new Host Details UI was made originally.

@sambible sambible requested review from omkarkhatavkar and a team October 24, 2023 21:33
@sambible sambible added locator Locator changes CherryPick PR needs CherryPick to previous branches 6.13.z 6.14.z labels Oct 24, 2023
@sambible sambible modified the milestone: GA Oct 24, 2023
@sambible sambible linked an issue Oct 24, 2023 that may be closed by this pull request
Revisit Virt card hardcoded locators #891
Closed
omkarkhatavkar
omkarkhatavkar approved these changes Oct 25, 2023
View reviewed changes
Copy link

@omkarkhatavkar omkarkhatavkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, nice work @sambible, pending some test result, please run PRT

@jyejare
Copy link
Member

jyejare commented Nov 30, 2023

@sambible Hello, Could you please run PRT as @omkarkhatavkar has requested above! Its helpful in merging / reviewing your PR !

@lhellebr
Copy link
Contributor

If you don't know what to run, pick a set of tests that are the MOST likely to get broken by the cleanup.

@sambible
Copy link
Contributor Author

Alright, sorry this took so long, but here it is: This is a printout of what fetching 'details' with the get_details method returns, which includes most of the cards that I've updated here
{'details': {'card_collapse_switch': 'Collapse all cards', 'system_properties': {'title': 'System properties', 'sys_properties': {'name': 'xmwdesrplz.6w6ge9ioee', 'domain': '6w6ge9ioee', 'model': 'Not available', 'tracer': 'Not installed', 'host_group': 'Not available', 'host_owner': 'host_qXY8N20cXw', 'owner_type': 'User', 'organization': 'WaHEeGn', 'location': 'gVpziz'}}, 'operating_system': {'title': 'Operating system', 'details': {'architecture': 'sdUnrsByvcZ', 'os': 'bHdkefjf 2', 'boot_time': 'Not available', 'kernel_release': 'Not available'}}, 'provisioning': {'title': 'Provisioning', 'details': {'build_duration': 'Not available', 'token': '9d5272a9-7084-4924-8bd7-2ba730eed6c6', 'pxe_loader': 'Not available'}}, 'bios': {'title': 'BIOS', 'details': {'vendor': 'Not available', 'version': 'Not available', 'release_date': 'Not available'}}, 'registration_details': {'details': {}}, 'hw_properties': {'details': {}}, 'provisioning_templates': {'title': 'Provisioning templates', 'templates_table': [{'column0': '', 'column1': 'Linux host_init_config default', 'column2': ''}]}, 'installed_products': {}, 'networking_interfaces': {'title': 'Networking interfaces', 'networking_interfaces_accordion': {}, 'edit_interfaces': 'Edit interfaces'}, 'networking_interface': {'title': 'System properties'}, 'virtualization': {'details': {}}}}

This is pretty barebones, since the host didn't have too much info, but you can see that it successfully reads all the cards like it would have before. Hopefully this is enough confidence to merge this PR :)

@omkarkhatavkar
Copy link

Alright, sorry this took so long, but here it is: This is a printout of what fetching 'details' with the get_details method returns, which includes most of the cards that I've updated here {'details': {'card_collapse_switch': 'Collapse all cards', 'system_properties': {'title': 'System properties', 'sys_properties': {'name': 'xmwdesrplz.6w6ge9ioee', 'domain': '6w6ge9ioee', 'model': 'Not available', 'tracer': 'Not installed', 'host_group': 'Not available', 'host_owner': 'host_qXY8N20cXw', 'owner_type': 'User', 'organization': 'WaHEeGn', 'location': 'gVpziz'}}, 'operating_system': {'title': 'Operating system', 'details': {'architecture': 'sdUnrsByvcZ', 'os': 'bHdkefjf 2', 'boot_time': 'Not available', 'kernel_release': 'Not available'}}, 'provisioning': {'title': 'Provisioning', 'details': {'build_duration': 'Not available', 'token': '9d5272a9-7084-4924-8bd7-2ba730eed6c6', 'pxe_loader': 'Not available'}}, 'bios': {'title': 'BIOS', 'details': {'vendor': 'Not available', 'version': 'Not available', 'release_date': 'Not available'}}, 'registration_details': {'details': {}}, 'hw_properties': {'details': {}}, 'provisioning_templates': {'title': 'Provisioning templates', 'templates_table': [{'column0': '', 'column1': 'Linux host_init_config default', 'column2': ''}]}, 'installed_products': {}, 'networking_interfaces': {'title': 'Networking interfaces', 'networking_interfaces_accordion': {}, 'edit_interfaces': 'Edit interfaces'}, 'networking_interface': {'title': 'System properties'}, 'virtualization': {'details': {}}}}

This is pretty barebones, since the host didn't have too much info, but you can see that it successfully reads all the cards like it would have before. Hopefully this is enough confidence to merge this PR :)

Thanks @sambible !

@omkarkhatavkar omkarkhatavkar merged commit b3dec1a into SatelliteQE:master Dec 18, 2023
5 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 18, 2023
@sambible @web-flow
Host Details Locator Cleanup (#1015)
9a947b3 
* Replace locators with hostdetailscard and remove unnecessary and unused entity methods

* Readd ladislav's functions

(cherry picked from commit b3dec1a)
github-actions bot pushed a commit that referenced this pull request Dec 18, 2023
@sambible @web-flow
Host Details Locator Cleanup (#1015)
1f4f997 
* Replace locators with hostdetailscard and remove unnecessary and unused entity methods

* Readd ladislav's functions

(cherry picked from commit b3dec1a)
This was referenced Dec 18, 2023
Merged
Merged
omkarkhatavkar pushed a commit that referenced this pull request Dec 19, 2023
@Satellite-QE @sambible
Host Details Locator Cleanup (#1015) (#1084)
cdcf115 
* Replace locators with hostdetailscard and remove unnecessary and unused entity methods

* Readd ladislav's functions

(cherry picked from commit b3dec1a)

Co-authored-by: Samuel Bible <[email protected]>
omkarkhatavkar pushed a commit that referenced this pull request Dec 19, 2023
@Satellite-QE @sambible
Host Details Locator Cleanup (#1015) (#1085)
cc8bd7c 
* Replace locators with hostdetailscard and remove unnecessary and unused entity methods

* Readd ladislav's functions

(cherry picked from commit b3dec1a)

Co-authored-by: Samuel Bible <[email protected]>
damoore044 pushed a commit to damoore044/airgun that referenced this pull request Jan 12, 2024
@sambible @damoore044
Host Details Locator Cleanup (SatelliteQE#1015)
07a61d4 
* Replace locators with hostdetailscard and remove unnecessary and unused entity methods

* Readd ladislav's functions
damoore044 pushed a commit to damoore044/airgun that referenced this pull request Jun 22, 2024
@sambible @damoore044
Host Details Locator Cleanup (SatelliteQE#1015)
e140ecd 
* Replace locators with hostdetailscard and remove unnecessary and unused entity methods

* Readd ladislav's functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LadislavVasina1 LadislavVasina1 LadislavVasina1 left review comments

@jyejare jyejare jyejare left review comments

@omkarkhatavkar omkarkhatavkar omkarkhatavkar approved these changes

Assignees

@sambible sambible

Labels
6.13.z 6.14.z CherryPick PR needs CherryPick to previous branches locator Locator changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Revisit Virt card hardcoded locators
5 participants
@sambible @jyejare @lhellebr @omkarkhatavkar @LadislavVasina1